refactor(cli): various code re-organization in hotswap code #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
force-pushed
the
mrgrain/refactor/code-re-org
branch
from
f878060 to
0cce2f5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 85.28% 84.82% -0.46%
==========================================
Files 218 218
Lines 36548 36530 -18
Branches 4600 4557 -43
==========================================
- Hits 31170 30988 -182
- Misses 5232 5396 +164
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iliapolo
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various straight-forward code re-organization changes and renames:
utilChangeHotswapResult->HotswapChange[]ClassifiedResourceChanges-> localizedClassifiedChangesNonHotswappableChange->RejectedChangerejectedChanges->rejectedPropertiescause that's what they arereportNonHotswappableChangeandreportNonHotswappableResourceto be non-mutating and only take actually used argsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license